diff --git a/.gitignore b/.gitignore index f247a0d..a5871a0 100644 --- a/.gitignore +++ b/.gitignore @@ -1,4 +1,4 @@ node_modules .web-extension-id -sign.sh web-ext-artifacts/ +sign-firefox-extension.sh diff --git a/README.md b/README.md index 424227f..8ec342a 100644 --- a/README.md +++ b/README.md @@ -1,30 +1,40 @@ Replaces YouTube comments with random herp derps. Click on the comment text to reveal the original. -This is modification of github.com/twstokes/herpderp +This is a fork of [twstokes/herpderp](https://github.com/twstokes/herpderp) with some modifications. Note: Ignores iframe embedded videos, including the chat replay iframe on YouTube livestream vids. +**Known bugs** +1. As of 2021-03-24, sometimes when showing the original comment the first few lines are missing. + This tends to happen when you've transitioned to the page from another video. Refreshing the page + tends to fix the problem. I'll eventually try to fix this. + ## Install **Firefox** * I have a signed xpi that you can immediately install. Open `build/` and drag the xpi into Firefox. + It may take a few seconds for the browser to display the extension installation dialog box. +* You can also find the signed Firefox files in the project's [Releases page](https://github.com/sir-pinecone/youtube-herp-derp-browser-extension/releases). **Chrome** -* Unzip the Chrome addon file in the `build` folder. -* Go to Chrome extensions page. Toggle the developer mode (top-right of page). Click `Load - unpacked`. -* Select the unzipped folder. +* Go to Chrome extensions page. +* Toggle the developer mode (top-right of page). +* Click `Load unpacked`. +* Select this project's root folder. ## Development ### Local Testing -In Firefox, open about:debugging and click `Load Temporary Add-on...` then select `manifest.json`. -file. +* Firefox: open about:debugging and click `Load Temporary Add-on...` then select `manifest.json` file. +* Chrome: follow the install steps from above. -### Signing and Building +## Signing and Building +### Firefox * Install web-ext with `$ npm install --global web-ext` * Generate an unlisted xpi with: - 'web-ext sign --channel unlisted --api-key --api-secret `. - Those keys can be obtained from https://addons.mozilla.org/en-US/developers/addon/api/key/ -* Drag downloaded xpi into Firefox. + `web-ext sign --api-key --api-secret ` + * You can obtain these keys from https://addons.mozilla.org/en-US/developers/addon/api/key/ +* The signed xpi will be in `web-ext-artifacts/`. Drag this into Firefox to install it. +* Alternatively use the private sign-firefox-extension.sh script (not included in the repo) which places the xpi in `build/`. + diff --git a/build/Chome_youtube_herp_derp-1.0.3-.zip b/build/Chome_youtube_herp_derp-1.0.3-.zip deleted file mode 100644 index 880cb78..0000000 Binary files a/build/Chome_youtube_herp_derp-1.0.3-.zip and /dev/null differ diff --git a/manifest.json b/manifest.json index 4a897e4..64b23ef 100644 --- a/manifest.json +++ b/manifest.json @@ -2,7 +2,7 @@ "manifest_version": 2, "name": "YouTube Herp Derp", "description": "Replaces YouTube comments with herp derps. Forked from github.com/twstokes/herpderp", - "homepage_url": "https://michael.is", + "homepage_url": "https://github.com/sir-pinecone/youtube-herp-derp-browser-extension", "version": "1.0.3", "icons": { "48": "icons/herp48.png", @@ -11,7 +11,7 @@ "content_scripts": [ { "run_at": "document_idle", - "all_frames": false, // Ignore iframes. + "all_frames": false, "matches": [ "https://apis.google.com/*", "https://plus.googleapis.com/*",